fix(hosted-url): activation of package on self-hosted url #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….12.0 to 4.0.0 fix(pub_updater): change defaultBaseUrl to 'https://pub.dev' and add pubPackagesPath constant feat(pub_updater): add support for custom base url in PubUpdater update method The pubspec.yaml file is updated to support a wider range of Dart SDK versions. The defaultBaseUrl constant is changed to 'https://pub.dev' to improve consistency with the naming conventions. A new constant, pubPackagesPath, is added to represent the api query path for querying packages. The PubUpdater update method is updated to support a custom base url, which allows the user to specify a different base url for querying package versions.
The version of the package has been reverted to 0.3.0. This is because the previous version 0.3.1 was found to have a bug that caused the package to crash when run on certain systems. The bug has been fixed and the package is now stable on version 0.3.0.
fix(hosted-url): activation of package on self-hosted url VeryGoodOpenSource#45
zoocityboy
requested review from
felangel,
jorgecoca,
renancaraujo and
wolfenrain
as code owners
renancaraujo
suggested changes
May 23, 2023
refac(parameters): change parameters
|
Hello there, sorry for the huge delay. We got a conflict on the pubspec. After that is fixed, LGTM. |
Sorry for the delay from my side, you know vacation time. Pubspec conflict is resolved. |
renancaraujo
approved these changes
Aug 1, 2023
wolfenrain
reviewed
Aug 1, 2023
Comment on lines
+75
to
+80
| if (_baseUrl != _defaultBaseUrl) ...[ | ||
| '--hosted-url', | ||
| _baseUrl, | ||
| '--source', | ||
| 'hosted' | ||
| ] |
There was a problem hiding this comment.
Just a nit, but technically we dont need this if statement right? It will work either way
There was a problem hiding this comment.
technically you're right, we don't need this if statement. but, do we need to override the default value with the same value? but as you wrote, it'll work either way. i can create yet another PR and remove this if statement :)
wolfenrain
approved these changes
Aug 1, 2023
erickzanardo
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes working with customBaseUrl and package activation.
If the base url is not https://pub.dev/ it adds a parameter -u hosted-url parameter to the activation command.
add support for flutter 3.10 by increasing environment sdk range <4.0.0
Type of Change