feat: increase min sdk constraint to 3.0.0 (#744)

* update to dart 3 * update to dart 3 * change update test * fix some tests
VeryGoodOpenSource · May 23, 2023 · 464696c · 464696c
1 parent af9b283
commit 464696c
Show file tree

Hide file tree

Showing 28 changed files with 231 additions and 215 deletions.
diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -27,7 +27,7 @@ jobs:
         flutter-version:
           # The version of Flutter to use should use the minimum Dart SDK version supported by the package,
           # refer to https://docs.flutter.dev/development/tools/sdk/releases.
-          - "3.7.0"
+          - "3.10.0"
         test:
           # E2E tests for the test command
           - test/commands/test/async_main/async_main_test.dart

diff --git a/.github/workflows/test_optimizer.yaml b/.github/workflows/test_optimizer.yaml
@@ -22,7 +22,7 @@ jobs:
   build_hooks:
     uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/dart_package.yml@v1
     with:
-      dart_sdk: 2.19.0
+      dart_sdk: 3.0.0
       working_directory: bricks/test_optimizer/hooks
 
   verify_bundle:

diff --git a/.github/workflows/very_good_cli.yaml b/.github/workflows/very_good_cli.yaml
@@ -25,7 +25,7 @@ jobs:
 
       - uses: subosito/flutter-action@v2.8.0
         with:
-          flutter-version: 3.7.12
+          flutter-version: 3.10.1
 
       - name: Install Dependencies
         run: flutter pub get

diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:very_good_analysis/analysis_options.4.0.0.yaml
+include: package:very_good_analysis/analysis_options.5.0.0.yaml
 analyzer:
   exclude:
     - "**/version.dart"
diff --git a/bricks/test_optimizer/hooks/analysis_options.yaml b/bricks/test_optimizer/hooks/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:very_good_analysis/analysis_options.4.0.0.yaml
+include: package:very_good_analysis/analysis_options.5.0.0.yaml
 linter:
   rules:
     public_member_api_docs: false
diff --git a/bricks/test_optimizer/hooks/pubspec.yaml b/bricks/test_optimizer/hooks/pubspec.yaml
@@ -2,7 +2,7 @@ name: hooks
 publish_to: none
 
 environment:
-  sdk: ">=2.19.0 <3.0.0"
+  sdk: ">=3.0.0 <4.0.0"
 
 dependencies:
   mason: ">=0.1.0-dev.49 <0.1.0"
@@ -12,5 +12,5 @@ dependencies:
 # the sdk constraints above
 dev_dependencies:
   mocktail: ^0.3.0
-  test: ^1.22.2
-  very_good_analysis: ^4.0.0
+  test: ^1.24.3
+  very_good_analysis: ^5.0.0
diff --git a/e2e/analysis_options.yaml b/e2e/analysis_options.yaml
@@ -1 +1 @@
-include: package:very_good_analysis/analysis_options.4.0.0.yaml
+include: package:very_good_analysis/analysis_options.5.0.0.yaml
diff --git a/e2e/helpers/command_helper.dart b/e2e/helpers/command_helper.dart
@@ -35,8 +35,7 @@ void Function() withRunner(
     Logger logger,
     PubUpdater pubUpdater,
     List<String> printLogs,
-  )
-      runnerFn,
+  ) runnerFn,
 ) {
   return _overridePrint((printLogs) async {
     final analytics = _MockAnalytics();

diff --git a/e2e/pubspec.yaml b/e2e/pubspec.yaml
@@ -4,16 +4,16 @@ version: 0.1.0+1
 publish_to: none
 
 environment:
-  sdk: ">=2.19.0 <3.0.0"
+  sdk: ">=3.0.0 <4.0.0"
 
 dev_dependencies:
   mason: ^0.1.0-dev.49
   mocktail: ^0.3.0
   path: ^1.8.0
-  pub_updater: ^0.2.4
-  test: ^1.19.2
+  pub_updater: ^0.3.0
+  test: ^1.24.3
   universal_io: ^2.0.4
   usage: ^4.0.2
-  very_good_analysis: ^4.0.0
+  very_good_analysis: ^5.0.0
   very_good_cli:
     path: ../
diff --git a/e2e/test/commands/test/async_main/fixture/pubspec.yaml b/e2e/test/commands/test/async_main/fixture/pubspec.yaml
@@ -4,8 +4,7 @@ version: 0.1.0+1
 publish_to: none
 
 environment:
-  sdk: ">=2.18.0 <3.0.0"
+  sdk: ">=3.0.0 <4.0.0"
 
 dev_dependencies:
-  test: ^1.19.2
-  test_api: 0.4.18
+  test: ^1.24.3
diff --git a/e2e/test/commands/test/compilation_error/fixture/pubspec.yaml b/e2e/test/commands/test/compilation_error/fixture/pubspec.yaml
@@ -3,7 +3,7 @@ version: 0.1.0+1
 publish_to: none
 
 environment:
-  sdk: ">=2.19.0 <3.0.0"
+  sdk: ">=3.0.0 <4.0.0"
 
 dev_dependencies:
-  test: ^1.19.2
+  test: ^1.24.3
diff --git a/e2e/test/commands/test/no_project/fixture/pubspec.yaml b/e2e/test/commands/test/no_project/fixture/pubspec.yaml
@@ -4,8 +4,8 @@ version: 0.1.0+1
 publish_to: none
 
 environment:
-  sdk: ">=2.18.0 <3.0.0"
+  sdk: ">=3.0.0 <4.0.0"
 
 dev_dependencies:
-  test: ^1.19.2
-  test_api: 0.4.18
+  test: ^1.24.3
+  test_api: 0.6.0
diff --git a/e2e/test/commands/test/spaced_golden_file_name/fixture/pubspec.yaml b/e2e/test/commands/test/spaced_golden_file_name/fixture/pubspec.yaml
@@ -3,7 +3,7 @@ description: Fixture for testing golden files with spaced file names.
 publish_to: none
 
 environment:
-  sdk: ">=2.18.0 <3.0.0"
+  sdk: ">=3.0.0 <4.0.0"
 
 dependencies:
   flutter:

diff --git a/lib/src/commands/create/templates/very_good_core/very_good_core_bundle.dart b/lib/src/commands/create/templates/very_good_core/very_good_core_bundle.dart
diff --git a/lib/src/commands/create/templates/very_good_dart_cli/very_good_dart_cli_bundle.dart b/lib/src/commands/create/templates/very_good_dart_cli/very_good_dart_cli_bundle.dart
diff --git a/lib/src/commands/create/templates/very_good_dart_package/very_good_dart_package_bundle.dart b/lib/src/commands/create/templates/very_good_dart_package/very_good_dart_package_bundle.dart
diff --git a/lib/src/commands/create/templates/very_good_flame_game/very_good_flame_game_bundle.dart b/lib/src/commands/create/templates/very_good_flame_game/very_good_flame_game_bundle.dart
diff --git a/...commands/create/templates/very_good_flutter_package/very_good_flutter_package_bundle.dart b/...commands/create/templates/very_good_flutter_package/very_good_flutter_package_bundle.dart