test everythin

VeryGoodOpenSource · May 18, 2023 · 9b3e136 · 9b3e136
1 parent 0de7d71
commit 9b3e136
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 15 deletions.
diff --git a/lib/src/cli/flutter_cli.dart b/lib/src/cli/flutter_cli.dart
@@ -401,15 +401,7 @@ Future<int> _flutterTest({
         if (optimizationApplied) {
           // When there is a test error before any group is computed, it means
           // that there is an error when compiling the test optimizer file.
-          if (groups.isEmpty) {
-            if (!event.isFailure && event.error.isCompilationError()) {
-              final relativeTestPath = p.relative(testPath, from: cwd);
-              failedTestErrorMessages[relativeTestPath] = [
-                '$prefix ${event.error}'
-              ];
-              return;
-            }
-          } else {
+          if (groups.isNotEmpty) {
             final topGroupName = _topGroupName(test, groups)!;
 
             testPath = testPath.replaceFirst(
@@ -579,8 +571,4 @@ extension on String {
   String toSingleLine() {
     return replaceAll('\n', '').replaceAll(RegExp(r'\s\s+'), ' ');
   }
-
-  bool isCompilationError() {
-    return contains('Compilation failed for');
-  }
 }
diff --git a/test/fixtures/test_runner_fixtures.dart b/test/fixtures/test_runner_fixtures.dart
@@ -1442,7 +1442,7 @@ List<Map<String, Object>> skipExceptionMessageJsonOutput(String cwd) => [
       {'success': false, 'type': 'done', 'time': 5466},
     ];
 
-List<Map<String, Object>> compulationErrorJsonOutput(String cwd) {
+List<Map<String, Object>> compilationErrorJsonOutput(String cwd) {
   return [
     {
       "protocolVersion": "0.1.1",

diff --git a/test/src/cli/flutter_cli_test.dart b/test/src/cli/flutter_cli_test.dart
@@ -741,7 +741,7 @@ void main() {
         File(p.join(tempDirectory.path, 'pubspec.yaml')).createSync();
 
         final testEventStream = Stream.fromIterable([
-          ...compulationErrorJsonOutput(tempDirectory.path)
+          ...compilationErrorJsonOutput(tempDirectory.path)
               .map(TestEvent.fromJson),
           const ExitTestEvent(exitCode: 1, time: 0),
         ]);