fix(test_optimizer): mismatch of versions on hook (#675)

* fix(test_optimizer): mismatch of versions on hook * comment
VeryGoodOpenSource · Mar 2, 2023 · d354745 · d354745
1 parent 6587fc8
commit d354745
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/.github/workflows/test_optimizer.yaml b/.github/workflows/test_optimizer.yaml
@@ -22,7 +22,7 @@ jobs:
   build_hooks:
     uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/dart_package.yml@v1
     with:
-      dart_sdk: 2.19.0
+      dart_sdk: 2.18.0
       working_directory: bricks/test_optimizer/hooks
 
   verify_bundle:

diff --git a/bricks/test_optimizer/hooks/analysis_options.yaml b/bricks/test_optimizer/hooks/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:very_good_analysis/analysis_options.4.0.0.yaml
+include: package:very_good_analysis/analysis_options.3.1.0.yaml
 linter:
   rules:
     public_member_api_docs: false
diff --git a/bricks/test_optimizer/hooks/pubspec.yaml b/bricks/test_optimizer/hooks/pubspec.yaml
@@ -8,7 +8,10 @@ dependencies:
   mason: ">=0.1.0-dev.41 <0.1.0"
   path: ^1.8.1
 
+
+# Beware: on hooks, even dev dependencies have to be compatible to all dart versions covered by
+# the sdk constraints above
 dev_dependencies:
   mocktail: ^0.3.0
   test: ^1.22.2
-  very_good_analysis: ^4.0.0
+  very_good_analysis: ^3.1.0
diff --git a/lib/src/commands/test/templates/test_optimizer_bundle.dart b/lib/src/commands/test/templates/test_optimizer_bundle.dart
@@ -35,7 +35,7 @@ final testOptimizerBundle = MasonBundle.fromJson(<String, dynamic>{
     {
       "path": "pubspec.yaml",
       "data":
-          "bmFtZTogaG9va3MKcHVibGlzaF90bzogbm9uZQoKZW52aXJvbm1lbnQ6CiAgc2RrOiAiPj0yLjE4LjAgPDMuMC4wIgoKZGVwZW5kZW5jaWVzOgogIG1hc29uOiAiPj0wLjEuMC1kZXYuNDEgPDAuMS4wIgogIHBhdGg6IF4xLjguMQoKZGV2X2RlcGVuZGVuY2llczoKICBtb2NrdGFpbDogXjAuMy4wCiAgdGVzdDogXjEuMjIuMgogIHZlcnlfZ29vZF9hbmFseXNpczogXjQuMC4wCg==",
+          "bmFtZTogaG9va3MKcHVibGlzaF90bzogbm9uZQoKZW52aXJvbm1lbnQ6CiAgc2RrOiAiPj0yLjE4LjAgPDMuMC4wIgoKZGVwZW5kZW5jaWVzOgogIG1hc29uOiAiPj0wLjEuMC1kZXYuNDEgPDAuMS4wIgogIHBhdGg6IF4xLjguMQoKCiMgQmV3YXJlOiBvbiBob29rcywgZXZlbiBkZXYgZGVwZW5kZW5jaWVzIGhhdmUgdG8gYmUgY29tcGF0aWJsZSB0byBhbGwgZGFydCB2ZXJzaW9ucyBjb3ZlcmVkIGJ5CiMgdGhlIHNkayBjb25zdHJhaW50cyBhYm92ZQpkZXZfZGVwZW5kZW5jaWVzOgogIG1vY2t0YWlsOiBeMC4zLjAKICB0ZXN0OiBeMS4yMi4yCiAgdmVyeV9nb29kX2FuYWx5c2lzOiBeMy4xLjAK",
       "type": "text"
     },
     {