Skip to content

Commit

Permalink
chore: update dependencies and sdk constraints (#782)
Browse files Browse the repository at this point in the history
* update dependencies and sdk constraints

* d format

* fix dartcli e2e test

* update plugin e2e test
  • Loading branch information
renancaraujo committed Sep 15, 2023
1 parent 51aab50 commit e86594d
Show file tree
Hide file tree
Showing 12 changed files with 227 additions and 228 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
flutter-version:
# The version of Flutter to use should use the minimum Dart SDK version supported by the package,
# refer to https://docs.flutter.dev/development/tools/sdk/releases.
- "3.10.0"
- "3.13.0"
test:
# E2E tests for the test command
- test/commands/test/async_main/async_main_test.dart
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/very_good_cli.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

- uses: subosito/flutter-action@v2.8.0
with:
flutter-version: 3.10.1
flutter-version: 3.13.0

- name: Install Dependencies
run: flutter pub get
Expand Down
2 changes: 1 addition & 1 deletion analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include: package:very_good_analysis/analysis_options.5.0.0.yaml
include: package:very_good_analysis/analysis_options.5.1.0.yaml
analyzer:
exclude:
- "**/version.dart"
5 changes: 2 additions & 3 deletions e2e/test/commands/create/dart_cli/dart_cli_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,14 @@ void main() {
[
'create',
'dart_cli',
'very_good_dart_cli',
'my_cli',
'-o',
tempDirectory.path,
],
);
expect(result, equals(ExitCode.success.code));

final workingDirectory =
path.join(tempDirectory.path, 'very_good_dart_cli');
final workingDirectory = path.join(tempDirectory.path, 'my_cli');

// add coverage to collect coverage on dart test
await expectSuccessfulProcessResult(
Expand Down
2 changes: 1 addition & 1 deletion e2e/test/commands/create/docs_site/docs_site_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ void main() {
'docs_site',
'very_good_docs_site',
'-o',
tempDirectory.path
tempDirectory.path,
],
);
expect(result, equals(ExitCode.success.code));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ void main() {
final tempDirectory = Directory.systemTemp.createTempSync();
addTearDown(() => tempDirectory.deleteSync(recursive: true));

const pluginName = 'very_good';
const pluginName = 'my_plugin';
final pluginDirectory = path.join(tempDirectory.path, pluginName);

final result = await commandRunner.run(
Expand Down
2 changes: 1 addition & 1 deletion lib/src/cli/cli.dart
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class _Cmd {
if (pr.exitCode != 0) {
final values = {
'Standard out': pr.stdout.toString().trim(),
'Standard error': pr.stderr.toString().trim()
'Standard error': pr.stderr.toString().trim(),
}..removeWhere((k, v) => v.isEmpty);

var message = 'Unknown error';
Expand Down
8 changes: 4 additions & 4 deletions lib/src/cli/flutter_cli.dart
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,9 @@ class Flutter {
...?arguments,
if (randomSeed != null) ...[
'--test-randomize-ordering-seed',
randomSeed
randomSeed,
],
if (optimizePerformance) p.join('test', _testOptimizerFileName)
if (optimizePerformance) p.join('test', _testOptimizerFileName),
],
stdout: stdout ?? noop,
stderr: stderr ?? noop,
Expand Down Expand Up @@ -273,7 +273,7 @@ Future<void> _verifyGitDependencies(
final gitDependencies = [
...dependencies.entries,
...devDependencies.entries,
...dependencyOverrides.entries
...dependencyOverrides.entries,
]
.where((entry) => entry.value is GitDependency)
.map((entry) => entry.value)
Expand Down Expand Up @@ -414,7 +414,7 @@ Future<int> _flutterTest({
final relativeTestPath = p.relative(testPath, from: cwd);
failedTestErrorMessages[relativeTestPath] = [
...failedTestErrorMessages[relativeTestPath] ?? [],
'$prefix $testName'
'$prefix $testName',
];
}

Expand Down
16 changes: 8 additions & 8 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,31 @@ documentation: https://cli.vgv.dev/docs/overview
topics: [cli, codegen, test, template, boilerplate]

environment:
sdk: ">=3.0.0 <4.0.0"
sdk: ">=3.1.0 <4.0.0"

dependencies:
args: ^2.1.0
cli_completion: ">=0.2.0 <0.4.0"
cli_completion: ^0.3.0
collection: ^1.17.1
glob: ^2.0.2
lcov_parser: ^0.1.2
mason: 0.1.0-dev.50
mason_logger: ^0.2.2
meta: ^1.3.0
path: ^1.8.0
pub_updater: ">=0.3.0 <0.4.0"
pub_updater: ^0.3.1
pubspec_parse: ^1.2.0
stack_trace: ^1.10.0
universal_io: ^2.0.4
very_good_test_runner: ^0.1.2

dev_dependencies:
build_runner: ^2.0.0
build_verify: ^3.0.0
build_version: ^2.0.0
mocktail: ">=0.3.0 <2.0.0"
build_runner: ^2.4.6
build_verify: ^3.1.0
build_version: ^2.1.1
mocktail: ^1.0.0
test: ^1.24.3
very_good_analysis: ^5.0.0
very_good_analysis: ^5.1.0

executables:
very_good:
Loading

0 comments on commit e86594d

Please sign in to comment.