-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom org name #148
Conversation
Co-authored-by: Felix Angelov <felangelov@gmail.com>
lib/src/commands/create.dart
Outdated
/// Gets the organization name. | ||
List<Map<String, String>> get _orgName { | ||
final orgName = | ||
(_argResults['org-name'] ?? 'com.example.verygoodcore') as String; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we create a constant _defaultOrgName = 'com.example.verygoodcore';
?
lib/src/commands/create.dart
Outdated
List<Map<String, String>> get _orgName { | ||
final orgName = | ||
(_argResults['org-name'] ?? 'com.example.verygoodcore') as String; | ||
_validateOrgName(orgName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we only need to validate if it's not the default? I think we can return the default early if the user didn't provide a custom org-name
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
@denangelov looks like the build is failing. Let me know if you need help fixing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Modified CLI to support additional argument for a custom organization name.
Type of Change