-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow force ansi output to enhance log readibility #534
Merged
renancaraujo
merged 1 commit into
VeryGoodOpenSource:main
from
agacemi:enhance-log-visibility-on-ci
Feb 16, 2023
Merged
feat: Allow force ansi output to enhance log readibility #534
renancaraujo
merged 1 commit into
VeryGoodOpenSource:main
from
agacemi:enhance-log-visibility-on-ci
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bee0756
to
a5b2d6b
Compare
6264575
to
cc9a39b
Compare
7 tasks
cc9a39b
to
dc8dc62
Compare
renancaraujo
previously approved these changes
Dec 12, 2022
felangel
reviewed
Dec 12, 2022
dcc70ae
to
9cea053
Compare
renancaraujo
previously approved these changes
Jan 19, 2023
wolfenrain
reviewed
Jan 20, 2023
223bc44
to
258a802
Compare
258a802
to
174471c
Compare
renancaraujo
approved these changes
Feb 16, 2023
wolfenrain
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to allow force ansi output even the output isn't tty. This option is helpful for CI like gitlab CI or other CI tools that support ansi output. This allows more readable log particularly the final report.
Code tested with Gitlab-CI.
Type of Change