Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow force ansi output to enhance log readibility #534

Merged
merged 1 commit into from
Feb 16, 2023
Merged

feat: Allow force ansi output to enhance log readibility #534

merged 1 commit into from
Feb 16, 2023

Conversation

agacemi
Copy link
Contributor

@agacemi agacemi commented Oct 29, 2022

Description

The aim of this PR is to allow force ansi output even the output isn't tty. This option is helpful for CI like gitlab CI or other CI tools that support ansi output. This allows more readable log particularly the final report.

Code tested with Gitlab-CI.

  • Without ansi-output

Capture d’écran 2022-10-30 à 00 55 58

  • With ansi-output

Capture d’écran 2022-10-30 à 00 57 19

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@agacemi agacemi force-pushed the enhance-log-visibility-on-ci branch from bee0756 to a5b2d6b Compare October 30, 2022 06:01
@agacemi agacemi changed the title Allow force ansi output to enhance log readibility (feat) Allow force ansi output to enhance log readibility Oct 30, 2022
@agacemi agacemi changed the title (feat) Allow force ansi output to enhance log readibility feat: Allow force ansi output to enhance log readibility Oct 30, 2022
@agacemi agacemi force-pushed the enhance-log-visibility-on-ci branch 2 times, most recently from 6264575 to cc9a39b Compare November 1, 2022 22:32
@agacemi agacemi mentioned this pull request Nov 11, 2022
Merged
7 tasks
@renancaraujo renancaraujo self-assigned this Dec 12, 2022
renancaraujo
renancaraujo previously approved these changes Dec 12, 2022
View reviewed changes
@renancaraujo renancaraujo removed their assignment Dec 12, 2022
@agacemi agacemi force-pushed the enhance-log-visibility-on-ci branch 2 times, most recently from dcc70ae to 9cea053 Compare December 19, 2022 15:19
@renancaraujo renancaraujo self-assigned this Jan 6, 2023
@renancaraujo renancaraujo removed their assignment Jan 19, 2023
renancaraujo
renancaraujo previously approved these changes Jan 19, 2023
View reviewed changes
@renancaraujo renancaraujo added the waiting for response Waiting for follow up label Jan 23, 2023
@agacemi agacemi force-pushed the enhance-log-visibility-on-ci branch 2 times, most recently from 223bc44 to 258a802 Compare February 8, 2023 03:51
@renancaraujo renancaraujo removed the waiting for response Waiting for follow up label Feb 13, 2023
wolfenrain
wolfenrain approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@wolfenrain wolfenrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@renancaraujo renancaraujo merged commit ff31511 into VeryGoodOpenSource:main Feb 16, 2023
@agacemi agacemi deleted the enhance-log-visibility-on-ci branch February 22, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

@felangel felangel Awaiting requested review from felangel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agacemi @renancaraujo @felangel @wolfenrain