Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont crash on test compilation error #739

Merged
merged 3 commits into from
May 22, 2023

Conversation

renancaraujo
Copy link
Contributor

@renancaraujo renancaraujo commented May 18, 2023

Description

fix: dont crash on test compilation error

fixes #727

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@renancaraujo renancaraujo force-pushed the renan/error-message-optmizdr branch 6 times, most recently from d9bc75b to e228cf8 Compare May 18, 2023 15:04
@renancaraujo renancaraujo marked this pull request as ready for review May 18, 2023 15:23
alestiago
alestiago previously approved these changes May 18, 2023
lib/src/cli/flutter_cli.dart Show resolved Hide resolved
lib/src/cli/flutter_cli.dart Outdated Show resolved Hide resolved
lib/src/cli/flutter_cli.dart Show resolved Hide resolved
@renancaraujo renancaraujo changed the title fix: test optimizer error path fix: dont crash on test compilation error May 19, 2023
@renancaraujo renancaraujo merged commit f19411c into main May 22, 2023
23 checks passed
@renancaraujo renancaraujo deleted the renan/error-message-optmizdr branch May 22, 2023 11:43
renancaraujo added a commit that referenced this pull request May 23, 2023
* fix: dont crash on test compilation error

* test everythin

* it is justa an and
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: very_good test failed (with exception)
2 participants