fix: fix test report in case of multiline test name #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
Oct 31, 2022
felangel
reviewed
Oct 31, 2022
| @@ -1120,6 +1120,21 @@ const skipExceptionMessageJsonOuput = [ | |||
| 'type': 'testStart', | |||
| 'time': 2757 | |||
| }, | |||
| { | |||
| 'test': { | |||
There was a problem hiding this comment.
can we move this test after id: 28 so that they are in order? Also we should update the testDone event to have a different timestamp
There was a problem hiding this comment.
Thank you @felangel for reviewing. Done
There was a problem hiding this comment.
Dear Reviewers @felangel @tomarra @erickzanardo @dewinjm , if you have a bit littre time to reviews my 4 PRs. We need them in our projet. Thank you in advance
agacemi
force-pushed
the
fix-multiline-test-name
branch
from
17bb3a3
to
b8f8276
Compare
agacemi
force-pushed
the
fix-multiline-test-name
branch
from
b8f8276
to
63365c8
Compare
7 tasks
agacemi
force-pushed
the
fix-multiline-test-name
branch
from
63365c8
to
e9bfc27
Compare
agacemi
force-pushed
the
fix-multiline-test-name
branch
from
b77c97a
to
ecb384f
Compare
renancaraujo
approved these changes
Jan 19, 2023
wolfenrain
approved these changes
Jan 20, 2023
felangel
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix a bug in case of mutliline test name. The truncate algorithm give a too short name and thus not helpful to find the test
Type of Change