fix: Prefer delegation implementation to allow comparator extension #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agacemi
requested review from
felangel,
wolfenrain and
renancaraujo
as code owners
agacemi
force-pushed
the
prefer-delegation
branch
from
9f6b30d
to
395a760
Compare
|
Dear reviewer, @renancaraujo don't hesitate to tell me if you need further information about real use case .. |
renancaraujo
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Overall it looks good. Would you be comfortable with making an e2e test for this after it is merged into the CLI @agacemi ?
erickzanardo
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix the following issue. #741 . I suggest to modify the current implementation of _TestOptimizationAwareGoldenFileComparator. .
This change, in my opinion isnt' a breaking change as
LocalFileComparatoris the default implementation.Type of Change