Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: defined PubLicense to get packages' licenses #818

Merged
merged 23 commits into from
Oct 4, 2023
Merged

feat: defined PubLicense to get packages' licenses #818

merged 23 commits into from
Oct 4, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Sep 29, 2023 •
edited
Loading

Description

Relates to #771

Changes:

  • Adds pub_license.dart to enable extracting the license information from pub.dev
  • Updates the analysis options to avoid the local analyzer reporting failures on brick

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago added the feature A new feature or request label Sep 29, 2023
@alestiago alestiago self-assigned this Sep 29, 2023
@alestiago alestiago changed the title feat: include script to get pub's licenses feat: include script to get package's licenses Sep 29, 2023
@alestiago alestiago changed the title feat: include script to get package's licenses feat: include script to get a package's licenses Sep 29, 2023
@alestiago alestiago changed the title feat: include script to get a package's licenses feat: defined PubLicense to get a package's licenses Sep 29, 2023
@alestiago alestiago changed the title feat: defined PubLicense to get a package's licenses feat: defined PubLicense to get packages' licenses Sep 29, 2023
renancaraujo
renancaraujo previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏾👏🏾👏🏾👏🏾👏🏾👏🏾👏🏾👏🏾👏🏾👏🏾👏🏾

lib/src/pub_license/pub_license.dart Outdated Show resolved Hide resolved
test/src/pub_license/fixtures/generate_pub_license_fixtures.dart Show resolved Hide resolved
@alestiago alestiago merged commit e30b629 into main Oct 4, 2023
27 checks passed
@alestiago alestiago deleted the alestiago/pub-license-imp branch October 4, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@felangel felangel Awaiting requested review from felangel

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees

@alestiago alestiago

Labels
feature A new feature or request
Projects
VGV Open Source 🦄 🧙🌟
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alestiago @erickzanardo @renancaraujo @wolfenrain