Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid failure when running local tests #820

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Conversation

alestiago
Copy link
Contributor

Description

Resolves #819

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

@alestiago alestiago added the documentation Improvements or additions to documentation label Sep 29, 2023
@alestiago alestiago self-assigned this Sep 29, 2023
@alestiago alestiago marked this pull request as ready for review September 29, 2023 13:26
@alestiago alestiago merged commit e72fe4f into main Sep 29, 2023
26 checks passed
@alestiago alestiago deleted the alestiago/running-tests branch September 29, 2023 13:53
@@ -31,7 +31,7 @@ jobs:
run: flutter pub get

- name: Format
run: dart format --set-exit-if-changed .
run: dart format --set-exit-if-changed lib test

- name: Analyze
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has a dart test with the args: -x e2e. We should remove that since that tag e2e doesnt exist on the CLI anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

some tests are failing on running dart test
2 participants