Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid disabling test optimization when passing extra args #826

Merged
merged 11 commits into from
Oct 3, 2023
Merged

fix: avoid disabling test optimization when passing extra args #826

merged 11 commits into from
Oct 3, 2023

Conversation

alestiago
Copy link
Contributor

Description

Resolves #772

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago self-assigned this Oct 2, 2023
@alestiago alestiago changed the title fix: avoid passing extra args disabling test optimization fix: avoid disabling test optimization when passing extra args Oct 3, 2023
@alestiago alestiago marked this pull request as draft October 3, 2023 10:15
@alestiago alestiago marked this pull request as ready for review October 3, 2023 11:45
@alestiago alestiago marked this pull request as draft October 3, 2023 11:56
@alestiago alestiago force-pushed the alestiago/fix-rest-disabling-optimization branch from 591e2f6 to 11e446d Compare October 3, 2023 12:06
@alestiago alestiago marked this pull request as ready for review October 3, 2023 13:05
@renancaraujo renancaraujo merged commit 66529fa into main Oct 3, 2023
26 checks passed
@renancaraujo renancaraujo deleted the alestiago/fix-rest-disabling-optimization branch October 3, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

@felangel felangel Awaiting requested review from felangel

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees

@alestiago alestiago

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: passing extra args disables test optimization
2 participants
@alestiago @renancaraujo