Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make all mock class to private #838

Merged
merged 5 commits into from
Oct 6, 2023
Merged

refactor: make all mock class to private #838

merged 5 commits into from
Oct 6, 2023

Conversation

droidbg
Copy link
Contributor

@droidbg droidbg commented Oct 4, 2023

Description

I've updated all the mock classes presented in the code, changing them from public to private mocks.

Private Mocks are useful for a few reasons:

  1. They make it clear that they should only be used in that specific test file.
  2. They help keep the test file tidy and self-contained, so it doesn't rely on stuff from other test files.
  3. They prevent accidental use in the wrong places.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Related Tickets & Documents

renancaraujo
renancaraujo approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀🚀

@alestiago alestiago merged commit 28e0032 into VeryGoodOpenSource:main Oct 6, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

@alestiago alestiago alestiago approved these changes

@felangel felangel Awaiting requested review from felangel

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: all Mocks should be private
3 participants
@droidbg @renancaraujo @alestiago