Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --ignore-failures to check licenses #846

Merged
merged 35 commits into from
Oct 12, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Oct 10, 2023

Should be merged after #842

Description

Adds a flag (--ignore-failures) on very_good packages check licenses.

This change anticipates #771

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago self-assigned this Oct 10, 2023
@alestiago alestiago changed the title feat: allow --ignore-failures on check licenses feat: add --ignore-failures to check licenses Oct 10, 2023
@alestiago alestiago added the feature A new feature or request label Oct 10, 2023
Base automatically changed from alestiago/licenses-fetch to main October 11, 2023 07:16
@alestiago alestiago marked this pull request as ready for review October 11, 2023 07:28
Copy link
Contributor

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, but LGTM already

@alestiago alestiago merged commit 8d7c6c3 into main Oct 12, 2023
26 checks passed
@alestiago alestiago deleted the alestiago/licenses-ignore-failures branch October 12, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants