Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add skip-packages to check licenses #854

Merged
merged 97 commits into from
Oct 17, 2023
Merged

feat: add skip-packages to check licenses #854

merged 97 commits into from
Oct 17, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Oct 16, 2023 •
edited
Loading

Should be merged after #850

Description

Adds a multi option (--skip-packages) on very_good packages check licenses.

This change anticipates #771

Demonstration

CleanShot.2023-10-17.at.09.07.13.mp4

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago
feat: include hidden check licenses command
cbc6c9b
@alestiago
coverage
bd6e631
@alestiago
typo
9dfc476
@alestiago
analyzer
2c416f7
@alestiago
Merge branch 'main' into alestiago/include-hidden-check-command
6eeb7a4
@alestiago
feat: allow fetching licenses
5b9fe36
@alestiago
full stop
31cc3a0
@alestiago
_isHostedDirectDependency
d13d6dc
@alestiago
Merge branch 'main' into alestiago/licenses-fetch
5cf0b0b
@alestiago
Merge remote-tracking branch 'origin' into alestiago/licenses-fetch
924c51b
@alestiago
testing
fe5a5dd
@alestiago
licenses and packages singular
19414b1
@alestiago
included TODOs
5f0af9d
@alestiago
test progress
d434f6f
@alestiago
Merge branch 'main' into alestiago/licenses-fetch
225837c
@alestiago
refactor to "dependencyName"
71c965b
@alestiago
refactor _tryParsePubspecLock
754728b
@alestiago
remove old ignore
d88047d
@alestiago
missing cancel
ba9c203
@alestiago
remove commented code
ad09a3c
@alestiago
words
4da6306
@alestiago
words
6d5a23d
@alestiago
removed argResults override
cf25b30
@alestiago
feat: allow ignoring failures when checking licenses
94657b5
@alestiago
used const
3a03531
@alestiago
testing
eec1abf
@alestiago
more tests and fixes
928e699
@alestiago
test progress update
6fac91b
@alestiago
removed TODO
f75c0d5
@alestiago
refactor _composeReport
b1c49e4
@alestiago alestiago added the feature A new feature or request label Oct 16, 2023
@alestiago alestiago self-assigned this Oct 16, 2023
@alestiago alestiago marked this pull request as draft October 16, 2023 10:36
@alestiago alestiago mentioned this pull request Oct 16, 2023
Merged
7 tasks
Base automatically changed from alestiago/forbidden-licenses to main October 16, 2023 13:05
@alestiago alestiago marked this pull request as ready for review October 16, 2023 13:10
wolfenrain
wolfenrain previously approved these changes Oct 17, 2023
View reviewed changes
@alestiago alestiago merged commit 0662587 into main Oct 17, 2023
26 checks passed
@alestiago alestiago deleted the alestiago/skip-packages branch October 17, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

@felangel felangel Awaiting requested review from felangel

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees

@alestiago alestiago

Labels
feature A new feature or request
Projects
VGV Open Source 🦄 🧙🌟
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alestiago @wolfenrain