fix: avoid failure when terminal has no columns #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alestiago
requested review from
felangel,
wolfenrain,
renancaraujo and
erickzanardo
as code owners
erickzanardo
previously approved these changes
Oct 25, 2023
wolfenrain
reviewed
Oct 26, 2023
wolfenrain
reviewed
Oct 26, 2023
alestiago
force-pushed
the
alestiago/specify-terminal-columns-default
branch
from
02ed473
to
cac996f
Compare
wolfenrain
approved these changes
Oct 26, 2023
erickzanardo
approved these changes
Oct 26, 2023
| void wrap( | ||
| String? text, { | ||
| required void Function(String?) print, | ||
| int? length, | ||
| }) { | ||
| final maxLength = length ?? stdout.terminalColumns; | ||
| final maxLength = switch (length) { | ||
| == null when stdout.hasTerminal => stdout.terminalColumns, |
There was a problem hiding this comment.
Oh, this is new to me, pretty cool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #866
Type of Change