Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reuse tempDirectory in setUp #880

Merged
merged 1 commit into from
Nov 10, 2023
Merged

test: reuse tempDirectory in setUp #880

merged 1 commit into from
Nov 10, 2023

Conversation

alestiago
Copy link
Contributor

Status

READY

Description

Small refactor that removed the redundant tempDirectory initialization.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago added the refactor A code change that neither fixes a bug nor add a feature label Nov 10, 2023
@alestiago alestiago self-assigned this Nov 10, 2023
@alestiago alestiago requested a review from a team as a code owner November 10, 2023 09:07
@alestiago alestiago merged commit b4ec78e into main Nov 10, 2023
26 checks passed
@alestiago alestiago deleted the test/reuse-license-check-temp-dir branch November 10, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

Assignees

@alestiago alestiago

Labels
refactor A code change that neither fixes a bug nor add a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alestiago @renancaraujo