Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

feat: add brick generator #4

Merged
merged 1 commit into from
Mar 16, 2023
Merged

feat: add brick generator #4

merged 1 commit into from
Mar 16, 2023

Conversation

renancaraujo
Copy link
Contributor

Description

feat: generate the brick

Generate the brick on top of the app base.

Blocked by #3

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@renancaraujo renancaraujo force-pushed the feat/add-generator branch 3 times, most recently from 4d0c5ca to 4a548c5 Compare March 13, 2023 20:28
@renancaraujo renancaraujo changed the title feat: generate the brick feat: add brick generator Mar 13, 2023
@renancaraujo renancaraujo marked this pull request as ready for review March 13, 2023 20:37
@renancaraujo renancaraujo mentioned this pull request Mar 13, 2023
Merged
7 tasks
omartinma
omartinma reviewed Mar 14, 2023
View reviewed changes
brick/hooks/pubspec.yaml Outdated Show resolved Hide resolved
alestiago
alestiago previously approved these changes Mar 14, 2023
View reviewed changes
@renancaraujo renancaraujo force-pushed the chore/add-app-base branch 2 times, most recently from b8c2ca2 to 423b331 Compare March 14, 2023 14:26
@renancaraujo renancaraujo force-pushed the feat/add-generator branch 3 times, most recently from a9ddd7f to 3df4730 Compare March 14, 2023 14:56
@renancaraujo renancaraujo marked this pull request as draft March 15, 2023 15:21
Base automatically changed from chore/add-app-base to main March 15, 2023 18:25
@renancaraujo renancaraujo marked this pull request as ready for review March 15, 2023 18:33
@renancaraujo renancaraujo requested review from alestiago and removed request for omartinma March 15, 2023 18:33
alestiago
alestiago approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@alestiago alestiago left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generator code feels hacky (as it follows the other generator patterns), I think we should invest some time into making them boring at some point, but that's beyond this PR.

@renancaraujo renancaraujo merged commit 6752798 into main Mar 16, 2023
@renancaraujo renancaraujo deleted the feat/add-generator branch March 16, 2023 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@omartinma omartinma omartinma left review comments

@alestiago alestiago alestiago approved these changes

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@renancaraujo @omartinma @alestiago