Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command-line switch '/mt' and '/mbt' #48

Conversation

RammerChoi
Copy link
Contributor

@RammerChoi RammerChoi commented Jul 28, 2017

'/mt' and '/mbt' are switches to select AttachMode when attaching a process by using an '/a' option.
'/mt' is an option to profile "main thread".
And '/mbt' is an option to profile "most busy thread".

This pull request is refactored from #47 on a new branch.
Thanks for your kind review.

@CyberShadow
Copy link
Member

As mentioned in the first PR, could you please split out the refactoring changes into separate commits of their own?

@RammerChoi
Copy link
Contributor Author

Sorry. I got it.
Please wait a minute.

@RammerChoi RammerChoi force-pushed the feature/add-command-line-attach-option branch from 59ef20f to cb08850 Compare July 29, 2017 01:16
@RammerChoi
Copy link
Contributor Author

I split out the refactoring changes into separate commits.
Please review again. Thanks.

@CyberShadow
Copy link
Member

Sorry for the delay. I'll look at this soon.

@CyberShadow
Copy link
Member

Looks good, thanks!

@CyberShadow CyberShadow merged commit 6e5e99d into VerySleepy:master Aug 7, 2017
@RammerChoi RammerChoi deleted the feature/add-command-line-attach-option branch August 28, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants