Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong spelling of delimeter #215

Closed
abhisekp opened this issue Mar 24, 2018 · 2 comments
Closed

Wrong spelling of delimeter #215

abhisekp opened this issue Mar 24, 2018 · 2 comments

Comments

@abhisekp
Copy link

abhisekp commented Mar 24, 2018 •
edited
Loading

Shuffle version

v5.1.1

Reproduction Link

Steps to reproduce

The spelling of delimeter in the option should be delimiter instead.

What is Expected?

Spell Check: delimiter
For backward compatibility, also accept delimeter along with delimiter (alias)

What is actually happening?

Developers are going crazy due to unnatural spelling 😺
Sometimes, developers type the correct spelling and nothing works showing a JSON parse error.
Vestride added a commit that referenced this issue Mar 26, 2018
@Vestride
Fix misspelled delimiter option #215
f72f57d
@Vestride
Copy link
Owner

Thanks! 😬

@Vestride
Copy link
Owner

Published in 5.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vestride @abhisekp