-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.0 cuts last element before moving it to the next row #46
Comments
Could you post a link to your demo please. On Monday, October 20, 2014, Lauri Kainulainen notifications@github.com
Sent with my thumbs |
Didn't have a demo I could publish, but here's one now: http://jsfiddle.net/luopio/oo63amox/1/. If you make the result window smaller, it'll allow the last element to cut before moving it to row 2. |
Thanks, for the demo, I see what the issue is. The I had added this buffer value because reading the width of elements isn't precise enough and was causing columns to jump between values. I do not remember why I set it so high though. I'll need to play around with this value. Maybe it should be customizable too. |
Released v3.1.0. There is now a new option |
Everything works beautifully in 2.1.1. I'm testing by using the same layout, same JS code and just switching between release 3.0.0 and 2.1.1:
$('.properties-listing-container').shuffle({
itemSelector: '.property-listing',
columnWidth: 300,
gutterWidth: 20
});
Container is a div with article-elements inside. Article has fixed width of 300px.
v2.1.1 works correctly:
![v2 1 1](https://cloud.githubusercontent.com/assets/69383/4697414/a9aef03a-5825-11e4-950c-aa1cf58483d2.png)
v3.0.0 won't update until around 1160px container width, which results in cutting the last element. Also note the behaviour on second line.
![v3 0 0](https://cloud.githubusercontent.com/assets/69383/4697413/a9ab725c-5825-11e4-8421-7400f35fd650.png)
Same thing happens in FF (33) and Chrome on Ubuntu 14.04. Also witnessed on Mac by other devs in my team.
The text was updated successfully, but these errors were encountered: