Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part of right column overlapped because of COLUMN_THRESHOLD #66

Closed
andrejsramko opened this issue Feb 25, 2015 · 3 comments
Closed

part of right column overlapped because of COLUMN_THRESHOLD #66

andrejsramko opened this issue Feb 25, 2015 · 3 comments

Comments

@andrejsramko
Copy link

this part causes little problems for me, when I'm trying to resize my window:

var calculatedColumns = (containerWidth + gutter) / columnWidth;

  // Widths given from getComputedStyle are not precise enough...
  if ( Math.abs(Math.round(calculatedColumns) - calculatedColumns) < COLUMN_THRESHOLD ) {
    // e.g. calculatedColumns = 11.998876
    calculatedColumns = Math.round( calculatedColumns );
  }

  this.cols = Math.max( Math.floor(calculatedColumns), 1 );

  // in my case NOK:
  // cols:4 containerWidth:925 colWidth:250
  // (75px of the right column covered)

The COLUMN_THRESHOLD constant causes that for example this.cols change
from 4 to 3 after the right container border one third of the 4th column overlaps...

Wouldn't it be possible / good to make the COLUM_THRESHOLD adjustable and not constant?

@Vestride
Copy link
Owner

It would. See #46

@andrejsramko
Copy link
Author

sorry for redundance. I have overseen the issue.

@Vestride
Copy link
Owner

No worries.

On Wednesday, February 25, 2015, andrejsramko notifications@github.com
wrote:

sorry for redundance. I have overseen the issue.


Reply to this email directly or view it on GitHub
#66 (comment).

Sent with my thumbs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants