Enum sizes #308
Merged
Enum sizes #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
approved these changes
Jun 23, 2022
src/Parser.zig
Outdated
| @@ -2076,6 +2087,40 @@ const Enumerator = struct { | |||
| e.res = res; | |||
| // TODO adjust res type to try to fit with the previous type | |||
| } | |||
|
|
|||
| fn tagSpec(e: *const Enumerator, p: *Parser, is_packed: bool, tok: TokenIndex) !Type.Specifier { | |||
There was a problem hiding this comment.
The spec in enumSpec and recordSpec comes from the official grammar, maybe it would be better to call this getTagType or even just tagType?
Closed
clang also tracks the promotion type of enums but that *seems* to be a C++ feature
This is a C++ feature that clang supports for C as an extension.
|
Thanks for this! This might still need some tweaking to match clang, on my machine clang says the enum in Also sorry for hijacking your branch at the end. I assumed you were done with this thought to add the two missing parts so that this PR would get enums to a (mostly) complete state but they turned out to be more complex than I assumed. |
|
Sounds good! I can take a look at the overflowed enums |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate enum sizes, accounting for packed attributes and overflow