-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.0.0 #25
Release v2.0.0 #25
Conversation
@Red-GV: GitHub didn't allow me to request PR reviews from the following users: btaani. Note that only ViaQ members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Helpful diff: v1.1.1 -> this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version seems to be fine except for the lint error (used it in a project which was already migrated to v1.1.1). If we want to remove the Go versions from the CI then the project configuration needs an update before this PR can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more questions occurred to me while reading a bit more into the source.
/hold |
/cancel hold @xperimental The API bits are largely done. I just need to finish cleaning up the test cases and seeing which parts need to be moved or if some are not needed anymore. |
/hold cancel Should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really awesome and the tests are a big source of understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the current version on the elasticsearch-operator again. We're on the right track, but I think we can reduce the module API even further.
@periklis Can you change the configuration of this repo, so that only the 1.17 build is "required" as we have taken out the 1.15 and 1.16 builds, so they will not report a status anymore. |
This PR is a follow up from #23. This reverts the previous PR by restoring the v1.1.1 (now retracted) build. This will now be used as a v2.X build instead, as detailed in #23.
/cc @xperimental @btaani
/assign @periklis
JIRA: https://issues.redhat.com/browse/LOG-2486