Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0 #25

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Release v2.0.0 #25

merged 2 commits into from
Apr 19, 2022

Conversation

Red-GV
Copy link
Contributor

@Red-GV Red-GV commented Apr 8, 2022

This PR is a follow up from #23. This reverts the previous PR by restoring the v1.1.1 (now retracted) build. This will now be used as a v2.X build instead, as detailed in #23.

/cc @xperimental @btaani
/assign @periklis

JIRA: https://issues.redhat.com/browse/LOG-2486

@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2022

@Red-GV: GitHub didn't allow me to request PR reviews from the following users: btaani.

Note that only ViaQ members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This PR is a follow up from #23. This reverts the previous PR by restoring the v1.1.1 (now retracted) build. This will now be used as a v2.X build instead, as detailed in #23.

/cc @xperimental @btaani
/assign @periklis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xperimental
Copy link
Contributor

Helpful diff: v1.1.1 -> this PR

go.mod Show resolved Hide resolved
log/log.go Outdated Show resolved Hide resolved
Copy link
Contributor

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version seems to be fine except for the lint error (used it in a project which was already migrated to v1.1.1). If we want to remove the Go versions from the CI then the project configuration needs an update before this PR can be merged.

Copy link
Contributor

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more questions occurred to me while reading a bit more into the source.

log/log.go Outdated Show resolved Hide resolved
log/logsink.go Outdated Show resolved Hide resolved
MIGRATION.md Outdated Show resolved Hide resolved
@Red-GV
Copy link
Contributor Author

Red-GV commented Apr 11, 2022

/hold

@Red-GV
Copy link
Contributor Author

Red-GV commented Apr 11, 2022

/cancel hold

@xperimental The API bits are largely done. I just need to finish cleaning up the test cases and seeing which parts need to be moved or if some are not needed anymore.

@Red-GV
Copy link
Contributor Author

Red-GV commented Apr 12, 2022

/hold cancel

Should be good to go now.

MIGRATION.md Outdated Show resolved Hide resolved
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really awesome and the tests are a big source of understanding.

Copy link
Contributor

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the current version on the elasticsearch-operator again. We're on the right track, but I think we can reduce the module API even further.

MIGRATION.md Outdated Show resolved Hide resolved
MIGRATION.md Outdated Show resolved Hide resolved
log/log.go Outdated Show resolved Hide resolved
log/log.go Outdated Show resolved Hide resolved
log/log.go Outdated Show resolved Hide resolved
log/log.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
MIGRATION.md Outdated Show resolved Hide resolved
@xperimental
Copy link
Contributor

@periklis Can you change the configuration of this repo, so that only the 1.17 build is "required" as we have taken out the 1.15 and 1.16 builds, so they will not report a status anymore.
On a related note: need to find out why coveralls is not working anymore. Maybe it only works for PRs from repo-local branches.

@periklis periklis merged commit 4c73bbd into ViaQ:master Apr 19, 2022
@Red-GV Red-GV deleted the release-2.X branch June 3, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants