Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-3878: Enable php language multiline error detection in vector #136

Merged
merged 1 commit into from May 23, 2023

Conversation

cahartma
Copy link

@cahartma cahartma commented Apr 6, 2023

Description

Fixes minor issue and enables php language for multiline exception handling

/cc @syedriko @vimalk78
/assign @jcantrill

Links

@openshift-ci openshift-ci bot requested review from syedriko and vimalk78 April 6, 2023 17:25
@cahartma cahartma changed the title LOG-3878-enable-php-multiline-in-vector LOG-3878: Enable php language multiline error detection in vector Apr 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023

@cahartma: This pull request references LOG-3878 which is a valid jira issue.

In response to this:

Description

Fixes minor issue and enables php language for multiline exception handling

/cc @syedriko @vimalk78
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@syedriko
Copy link

/test unit

1 similar comment
@cahartma
Copy link
Author

/test unit

@alanconway
Copy link
Member

/approve
/lgtm

Copy link
Member

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jcantrill
Copy link
Member

/hold

@jcantrill
Copy link
Member

/retest

1 similar comment
@jcantrill
Copy link
Member

/retest

@cahartma cahartma force-pushed the LOG-3878-enable-php-multiline branch from 849816b to 1a7ca72 Compare April 25, 2023 15:36
@openshift-ci openshift-ci bot removed the lgtm label Apr 25, 2023
@cahartma cahartma changed the base branch from v0.21-rh to release-5.7 April 25, 2023 15:41
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2023

@cahartma: This pull request references LOG-3878 which is a valid jira issue.

In response to this:

Description

Fixes minor issue and enables php language for multiline exception handling

/cc @syedriko @vimalk78
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, cahartma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcantrill
Copy link
Member

/hold cancel

@jcantrill
Copy link
Member

/refresh

@jcantrill jcantrill merged commit b15f104 into ViaQ:release-5.7 May 23, 2023
32 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants