Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom item use cooldowns don't work #450

Closed
4 tasks done
VidTu opened this issue Apr 10, 2022 · 1 comment
Closed
4 tasks done

Custom item use cooldowns don't work #450

VidTu opened this issue Apr 10, 2022 · 1 comment
Labels
legacy 1.9-1.12 Bug, low priority/unsupported

Comments

@VidTu
Copy link

VidTu commented Apr 10, 2022

'/viaversion dump' Output

https://dump.viaversion.com/9f2c409337701d2716a574369ed0b64e585cbffe113b28d5e1d75305c73fbeb3

Console Error

No response

Bug Description

Custom (org.bukkit.Player.setCooldown(Material, int)) item use cooldowns don't work for 1.12.2 players on the 1.18.2 server

Steps to Reproduce

  1. Setup a 1.18.2 (paper) server.
  2. Join with the vanilla (1.12.2) client.
  3. Use the org.bukkit.Player.setCooldown(Material, int) method via some plugin.
  4. Notice the cooldown not displaying.

Expected Behavior

The cooldown should display, because its packet exists in 1.12.2

Additional Server Info

Test plugin code, compiled using latest (1.18.2-R0.1-SNAPSHOT) paper-api:

package test;

import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
import org.jetbrains.annotations.NotNull;

public class TestPlugin extends JavaPlugin {
    @Override
    public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command, @NotNull String label, @NotNull String[] args) {
        if (!(sender instanceof Player p)) return false;
        p.setCooldown(p.getInventory().getItemInMainHand().getType(), 200);
        return true;
    }
}

Checklist

  • Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. BungeeCord), not on both.
  • I have included a ViaVersion dump.
  • If applicable, I have included a paste (not a screenshot) of the error.
  • I have tried a build from https://ci.viaversion.com/ and the issue still persists.
@Barvalg
Copy link
Member

Barvalg commented Apr 10, 2022

Platform: git--Paper--283%20%28MC%3A%201.18.2%29
ViaVersion (4.3.0-22w14a-SNAPSHOT): Even with dev
ViaBackwards(4.3.0-22w14a-SNAPSHOT): Even with dev

kennytv added a commit that referenced this issue May 29, 2022
@kennytv kennytv added legacy 1.9-1.12 Bug, low priority/unsupported and removed unconfirmed labels May 29, 2022
@kennytv kennytv closed this as completed May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy 1.9-1.12 Bug, low priority/unsupported
Projects
None yet
Development

No branches or pull requests

3 participants