Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World Map Added #22

Closed
wants to merge 2 commits into from
Closed

World Map Added #22

wants to merge 2 commits into from

Conversation

hugomosh
Copy link

Added world map

Extracted from low-resolution map: https://www.amcharts.com/svg-maps/?map=world

Tested

@hugomosh
Copy link
Author

This time it fails beacuse


 FAIL  __tests__/radio-svg-map.test.js
  ● Test suite failed to run
    TypeError: Cannot assign to read only property 'Symbol(Symbol.toStringTag)' of object '#<process>'
      
      at exports.default (node_modules/jest-util/build/create_process_object.js:14:34)
 FAIL  __tests__/checkbox-svg-map.test.js
  ● Test suite failed to run
    TypeError: Cannot assign to read only property 'Symbol(Symbol.toStringTag)' of object '#<process>'
      
      at exports.default (node_modules/jest-util/build/create_process_object.js:14:34)
 FAIL  __tests__/svg-map.test.js
  ● Test suite failed to run
    TypeError: Cannot assign to read only property 'Symbol(Symbol.toStringTag)' of object '#<process>'
      
      at exports.default (node_modules/jest-util/build/create_process_object.js:14:34)

Related: jestjs/jest#8069

@VictorCazanave VictorCazanave added the enhancement New feature or request label Mar 15, 2019
@VictorCazanave
Copy link
Owner

Thanks @hugomosh 😃
I'll review it and fix the Jest bug this weekend

@codecov-io
Copy link

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          76     76           
  Branches       17     17           
=====================================
  Hits           76     76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40caff...a52b83a. Read the comment docs.

@VictorCazanave
Copy link
Owner

The new version of Node fixed the issue.

However as written in the contributing section, could you add:

  • a simple snapshot test (like the one of Utah)
  • the map with the list of locations (countries) in the maps section of README

In my test, the right part of Russia looks cropped. Do you have the same issue?

Screen Shot 2019-03-16 at 6 10 32 PM

@hugomosh
Copy link
Author

The new version of Node fixed the issue.

However as written in the contributing section, could you add:

  • a simple snapshot test (like the one of Utah)
  • the map with the list of locations (countries) in the maps section of README

In my test, the right part of Russia looks cropped. Do you have the same issue?

Screen Shot 2019-03-16 at 6 10 32 PM

Oh I see Russia cropped, my bad. It is the view port, I need to adjust it right to also not have whitespace.
Sure, I will write the information.

Thank you for the time spent.

@VictorCazanave VictorCazanave self-requested a review April 13, 2019 07:42
@VictorCazanave
Copy link
Owner

@hugomosh since v2.0.0 the maps have been moved to another package.
So if you still want to add the world map, could you re-create this PR on v1 branch or create a new one on svg-maps please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants