Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmui: incorrectly displayed graph in certain cases #2037

Closed
valyala opened this issue Jan 6, 2022 · 2 comments
Closed

vmui: incorrectly displayed graph in certain cases #2037

valyala opened this issue Jan 6, 2022 · 2 comments
Assignees
Labels
bug Something isn't working vmui UI for ad-hoc queries in VictoriaMetrics or VictoriaLogs

Comments

@valyala
Copy link
Collaborator

valyala commented Jan 6, 2022

Describe the bug
vmui incorrectly displays graphs in certain cases.

To Reproduce

  1. Run a query q - https://play.victoriametrics.com/select/accounting/1/6a716b0f-38bc-4856-90ce-448fd713e3fe/prometheus/graph/?g0.range_input=1d&g0.end_input=2022-01-05T20%3A06%3A35&g0.step_input=93.254&g0.tab=chart&g0.expr=sum(100*rate(process_cpu_seconds_total))%3E5.4 . All the gaps on the graph are displayed correctly when comparing to https://play.victoriametrics.com/select/accounting/1/6a716b0f-38bc-4856-90ce-448fd713e3fe/prometheus/graph/?g0.range_input=1d&g0.end_input=2022-01-05T20%3A06%3A35&g0.step_input=93.254&g0.tab=chart&g0.expr=sum(100*rate(process_cpu_seconds_total))

  2. Add default 0 to the end of the query - https://play.victoriametrics.com/select/accounting/1/6a716b0f-38bc-4856-90ce-448fd713e3fe/prometheus/graph/?g0.range_input=1d&g0.end_input=2022-01-05T20%3A06%3A35&g0.step_input=93.254&g0.tab=chart&g0.expr=sum(100*rate(process_cpu_seconds_total))%3E5.4%20default%200 . The graph is displayed incorrectly - the graph values are limited in the range 0...1. This is the bug in vmui, since VictoriaMetrics returns the correct data points for this query.

Expected behavior
The default 0 must fill gaps from the graph at step 1 with zeroes, while leaving the rest of the graph the same as at the step 1

Version
Commit c70c064 (the latest one now).

@valyala valyala added the vmui UI for ad-hoc queries in VictoriaMetrics or VictoriaLogs label Jan 6, 2022
@valyala
Copy link
Collaborator Author

valyala commented Jan 6, 2022

@valyala valyala added the bug Something isn't working label Jan 6, 2022
valyala added a commit that referenced this issue Jan 18, 2022
valyala added a commit that referenced this issue Jan 18, 2022
@valyala
Copy link
Collaborator Author

valyala commented Jan 18, 2022

This issue has been fixed in v1.72.0. Closing it.

@valyala valyala closed this as completed Jan 18, 2022
viperstars pushed a commit to viperstars/vmquerier that referenced this issue Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vmui UI for ad-hoc queries in VictoriaMetrics or VictoriaLogs
Projects
None yet
Development

No branches or pull requests

2 participants