Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add value "for" as a variable #3246

Closed
PavelKolobaev opened this issue Oct 17, 2022 · 2 comments
Closed

Add value "for" as a variable #3246

PavelKolobaev opened this issue Oct 17, 2022 · 2 comments
Labels
enhancement New feature or request vmalert

Comments

@PavelKolobaev
Copy link

Is your feature request related to a problem? Please describe.
We can use $labels.alertname to create message templates, but we cannot use $labels.for.

Describe the solution you'd like
Please add $labels.for

Additional context
vmalert v1.72.0
@hagen1778 hagen1778 added vmalert enhancement New feature or request labels Oct 17, 2022
@hagen1778 hagen1778 added the help wanted Extra attention is needed label Dec 7, 2022
hagen1778 added a commit that referenced this issue Dec 12, 2022
@hagen1778
vmalert: support $for or .For template variables
9f307ff 
support `$for` or `.For` template variables  in alert's annotations.

See #3246

Signed-off-by: hagen1778 <roman@victoriametrics.com>
@hagen1778 hagen1778 mentioned this issue Dec 12, 2022
Merged
f41gh7 pushed a commit that referenced this issue Dec 12, 2022
@hagen1778
vmalert: support $for or .For template variables (#3474)
8286f96 
support `$for` or `.For` template variables  in alert's annotations.

See #3246

Signed-off-by: hagen1778 <roman@victoriametrics.com>

Signed-off-by: hagen1778 <roman@victoriametrics.com>
valyala pushed a commit that referenced this issue Dec 12, 2022
@hagen1778 @valyala
vmalert: support $for or .For template variables (#3474)
a44af87 
support `$for` or `.For` template variables  in alert's annotations.

See #3246

Signed-off-by: hagen1778 <roman@victoriametrics.com>

Signed-off-by: hagen1778 <roman@victoriametrics.com>
@hagen1778
Copy link
Collaborator

@PavelKolobaev for support was added in #3474 and will be included to the next release.

@valyala valyala removed the help wanted Extra attention is needed label Dec 14, 2022
@valyala
Copy link
Collaborator

valyala commented Dec 14, 2022

The $labels.for template variable is available in vmalert starting from v1.85.1. Closing the feature request as done.

@valyala valyala closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request vmalert
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valyala @hagen1778 @PavelKolobaev