Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmagent metric_relabel_configs affect automatically generated timeseries #592

Closed
weenxin opened this issue Jun 29, 2020 · 2 comments · Fixed by #593
Closed

vmagent metric_relabel_configs affect automatically generated timeseries #592

weenxin opened this issue Jun 29, 2020 · 2 comments · Fixed by #593
Labels
bug Something isn't working

Comments

@weenxin
Copy link
Contributor

weenxin commented Jun 29, 2020

Describe the bug
According prometheus document ,

Metric relabeling does not apply to automatically generated timeseries such as up.

To Reproduce
some config with metric_relabel_configs with keep action(not include up metrics).

Expected behavior
the up metrics should not be removed.

Version

$ ./victoria-metrics-prod --version
vmagent-20200628-065703-heads-master-0-g05d754d-dirty-ff8a2fbe

Used command-line flags

bin/vmagent  \
-httpListenAddr=:8429 \
-memory.allowedPercent=70  \
-maxInsertRequestSize=1024000000 \
-promscrape.config=bin/prometheus.yaml \
-promscrape.maxScrapeSize=10240000000 \
-promscrape.configCheckInterval=1m \
-remoteWrite.tmpDataPath=data \
-remoteWrite.queues=50 \
-remoteWrite.maxBlockSize=1024000000 \
-remoteWrite.flushInterval=10s \
-remoteWrite.url=http://host1:8480/insert/1128/prometheus/api/v1/write  \
-remoteWrite.url=http://host2:8480/insert/1128/prometheus/api/v1/write  \
-remoteWrite.url=http://host3:8480/insert/1128/prometheus/api/v1/write  \
-remoteWrite.url=http://host4:8480/insert/1128/prometheus/api/v1/write
@valyala
Copy link
Collaborator

valyala commented Jun 30, 2020

The issue should be fixed in the commit 1cd01b5 . Leaving the issue open until the bugfix is included in the next release.

@valyala valyala reopened this Jun 30, 2020
@valyala
Copy link
Collaborator

valyala commented Jul 2, 2020

The bugfix has been included in v1.37.4. Closing the issue as fixed.

@valyala valyala closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants