Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Auto metrics relabeled errors #593

Merged
merged 3 commits into from Jun 29, 2020
Merged

Conversation

weenxin
Copy link
Contributor

@weenxin weenxin commented Jun 29, 2020

fix #592

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #593 into master will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   68.02%   67.89%   -0.13%     
==========================================
  Files         154      154              
  Lines       21225    21228       +3     
==========================================
- Hits        14438    14413      -25     
- Misses       5624     5656      +32     
+ Partials     1163     1159       -4     
Impacted Files Coverage Δ
lib/promscrape/scrapework.go 72.84% <100.00%> (+0.55%) ⬆️
lib/mergeset/block_stream_reader.go 50.96% <0.00%> (-11.62%) ⬇️
lib/storage/merge.go 76.85% <0.00%> (-3.31%) ⬇️
lib/mergeset/table.go 66.75% <0.00%> (-1.54%) ⬇️
lib/storage/index_db.go 76.03% <0.00%> (+0.16%) ⬆️
app/vmselect/promql/aggr_incremental.go 91.40% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ecfa3...701d048. Read the comment docs.

Copy link
Collaborator

@valyala valyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valyala valyala merged commit 1cd01b5 into VictoriaMetrics:master Jun 29, 2020
@valyala
Copy link
Collaborator

valyala commented Jun 29, 2020

@weenxin , thanks for the contribution!

valyala pushed a commit that referenced this pull request Jun 29, 2020
* Fix Auto metrics relabeled errors

* Finalize auto-genenated  Labels

* Fix Test Errors

Co-authored-by: xinyulong <xinyulong@kuaishou.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vmagent metric_relabel_configs affect automatically generated timeseries
2 participants