Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log aggregation #2576

Closed
wants to merge 5 commits into from
Closed

Log aggregation #2576

wants to merge 5 commits into from

Conversation

jelmd
Copy link
Contributor

@jelmd jelmd commented May 13, 2022

fix #2575

@jelmd
Copy link
Contributor Author

jelmd commented May 13, 2022

Just cherry pick cfbf414

@f41gh7 f41gh7 requested a review from valyala May 14, 2022 17:29
valyala added a commit that referenced this pull request May 25, 2022
@valyala
lib/promscrape: add -promscrape.suppressScrapeErrorsDelay command-lin…
796804e 
…e flag

This flag can be used for reducing the amounts of logs when scraping unreliable scrape targets.

See #2575

The patch is based on #2576 .
Thanks to @jelmd .
valyala added a commit that referenced this pull request May 25, 2022
@valyala
lib/promscrape: add -promscrape.suppressScrapeErrorsDelay command-lin…
f149d56 
…e flag

This flag can be used for reducing the amounts of logs when scraping unreliable scrape targets.

See #2575

The patch is based on #2576 .
Thanks to @jelmd .
@valyala
Copy link
Collaborator

valyala commented May 25, 2022

@jelmd , thanks for the pull request! I tried to simplify it in the 796804e . Could you check whether this works for your case?

@valyala valyala closed this May 25, 2022
@jelmd
Copy link
Contributor Author

jelmd commented May 28, 2022

Cool 👍 . Added some comments wrt. msg formatting and logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valyala valyala Awaiting requested review from valyala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log aggregation of scrape errors
2 participants
@jelmd @valyala