Add endpoint labels for pod targets #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbird86
force-pushed
the
fix/k8s_discovery_epp_name
branch
from
03e42ab
to
cc169c0
Compare
zekker6
approved these changes
May 5, 2023
|
@thunderbird86 PR cannot be merged because commit doesn't contain a verified signature, coulld you please configure signing and do a squash and force push to replace existing commit? |
…different ports Signed-off-by: Vasilchenko Anton <vasilchenko-as@yandex.ru>
thunderbird86
force-pushed
the
fix/k8s_discovery_epp_name
branch
from
cc169c0
to
d5e9472
Compare
|
@zekker6 sorry for inconvenience, done |
|
@thunderbird86 Thank you for the contribution! |
|
@zekker6 my pleasure |
valyala
pushed a commit
that referenced
this pull request
May 10, 2023
…different ports (#4253) Signed-off-by: Vasilchenko Anton <vasilchenko-as@yandex.ru>
valyala
pushed a commit
that referenced
this pull request
May 10, 2023
…different ports (#4253) Signed-off-by: Vasilchenko Anton <vasilchenko-as@yandex.ru>
valyala
pushed a commit
that referenced
this pull request
May 10, 2023
…different ports (#4253) Signed-off-by: Vasilchenko Anton <vasilchenko-as@yandex.ru>
|
FYI, this change has been included in v1.91.0 release. |
|
The bugfix has been backported to v1.87.6 LTS release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
__meta_kubernetes_endpoints_name,__meta_kubernetes_endpoints_label_<labelname>and__meta_kubernetes_endpoints_labelpresent_<labelname>labels for all targets discovered from ports not assigned to endpoint. Previously, ports not matched byServicedid not have this label. See [this issue]