fix inconsistent behaviors with prometheus when scraping #5153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5153 +/- ##
=======================================
Coverage 60.19% 60.20%
=======================================
Files 398 398
Lines 74120 74200 +80
=======================================
+ Hits 44618 44673 +55
- Misses 26991 27019 +28
+ Partials 2511 2508 -3
☔ View full report in Codecov by Sentry. |
Haleygo
force-pushed
the
fix-get-auth-header-err
branch
from
b16cbbd
to
f680eb9
Compare
Haleygo
force-pushed
the
fix-get-auth-header-err
branch
2 times, most recently
from
f93f49e
to
f9f7590
Compare
Haleygo
force-pushed
the
fix-get-auth-header-err
branch
4 times, most recently
from
451bb24
to
b1cd497
Compare
1. address #4959. skip job with wrong syntax in `scrape_configs` with error logs instead of exiting; 2. show error messages on vmagent /targets ui if there are wrong auth configs in `scrape_configs`, previously will print error logs and do scrape without auth header; 3. don't send requests if there are wrong auth configs in: 1. vmagent remoteWrite; 2. vmalert datasource/remoteRead/remoteWrite/notifier.
Haleygo
force-pushed
the
fix-get-auth-header-err
branch
from
b1cd497
to
179a3d1
Compare
|
@Haleygo , thanks for the pull request! It looks great overall. I noticed a few issues while reviewing the pull request - some of these issues existed before this pull request. I'd recommend taking a look at the follow-up commit, which addresses these issues - d5a599b . If you notice some issues in this commit, then feel free sending follow-up pull requests on top of this commit! |
valyala
pushed a commit
that referenced
this pull request
Oct 26, 2023
* fix inconsistent behaviors with prometheus when scraping 1. address #4959. skip job with wrong syntax in `scrape_configs` with error logs instead of exiting; 2. show error messages on vmagent /targets ui if there are wrong auth configs in `scrape_configs`, previously will print error logs and do scrape without auth header; 3. don't send requests if there are wrong auth configs in: 1. vmagent remoteWrite; 2. vmalert datasource/remoteRead/remoteWrite/notifier. * add changelogs * address review comments * fix ut
AndrewChubatiuk
pushed a commit
to AndrewChubatiuk/VictoriaMetrics
that referenced
this pull request
Nov 15, 2023
…rics#5153) * fix inconsistent behaviors with prometheus when scraping 1. address VictoriaMetrics#4959. skip job with wrong syntax in `scrape_configs` with error logs instead of exiting; 2. show error messages on vmagent /targets ui if there are wrong auth configs in `scrape_configs`, previously will print error logs and do scrape without auth header; 3. don't send requests if there are wrong auth configs in: 1. vmagent remoteWrite; 2. vmalert datasource/remoteRead/remoteWrite/notifier. * add changelogs * address review comments * fix ut
|
FYI, this pull request has been included in v1.95.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrape_configswith error logs instead of exiting;scrape_configs, previously will print error logs and do scrape without auth header;