Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inconsistent behaviors with prometheus when scraping #5153

Merged
merged 4 commits into from Oct 17, 2023
Merged

fix inconsistent behaviors with prometheus when scraping #5153

merged 4 commits into from Oct 17, 2023

Commits on Oct 17, 2023

  1. fix inconsistent behaviors with prometheus when scraping 

    1. address #4959. skip job with wrong syntax in `scrape_configs` with error logs instead of exiting;
2. show error messages on vmagent /targets ui if there are wrong auth configs in `scrape_configs`, previously will print error logs and do scrape without auth header;
3. don't send requests if there are wrong auth configs in:
    1. vmagent remoteWrite;
    2. vmalert datasource/remoteRead/remoteWrite/notifier.
    @Haleygo
    Haleygo committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    14a5e68 View commit details
    Browse the repository at this point in the history

  2. add changelogs

    @Haleygo
    Haleygo committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    a828570 View commit details
    Browse the repository at this point in the history

  3. address review comments

    @Haleygo
    Haleygo committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    02ea977 View commit details
    Browse the repository at this point in the history

  4. fix ut

    @Haleygo
    Haleygo committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    179a3d1 View commit details
    Browse the repository at this point in the history