Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/vmagent: removed deprecated -remoteWrite.multitenantURL flag support #6253

Merged
merged 2 commits into from
May 13, 2024

Conversation

AndrewChubatiuk
Copy link
Contributor

Describe Your Changes

Removed deprecated -remoteWrite.multitenantURL flag to simplify global stream aggregation

Please provide a brief description of the changes you made. Be as specific as possible to help others understand the purpose and impact of your modifications.

Checklist

The following checks are mandatory:

@AndrewChubatiuk AndrewChubatiuk force-pushed the removed-deprecated-multitenant-config branch 3 times, most recently from 3c323b9 to a03f122 Compare May 11, 2024 06:02
@hagen1778 hagen1778 requested review from zekker6 and f41gh7 May 13, 2024 08:39
Copy link
Collaborator

@hagen1778 hagen1778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hagen1778 hagen1778 force-pushed the removed-deprecated-multitenant-config branch from 2e29c39 to 865a964 Compare May 13, 2024 13:19
@hagen1778 hagen1778 merged commit 680b8c2 into master May 13, 2024
5 of 6 checks passed
@hagen1778 hagen1778 deleted the removed-deprecated-multitenant-config branch May 13, 2024 13:22
hagen1778 pushed a commit that referenced this pull request May 13, 2024
…ort (#6253)

Removed deprecated `-remoteWrite.multitenantURL` flag to simplify global
stream aggregation

---------

Signed-off-by: hagen1778 <roman@victoriametrics.com>
Co-authored-by: hagen1778 <roman@victoriametrics.com>
(cherry picked from commit 680b8c2)
valyala added a commit that referenced this pull request Jul 13, 2024
…ad of old link

The old link was changed globally to the new link in the commit f4b1cbf .
Unfortunately, old links are still posted in new commits :(

This is a follow-up for 680b8c2 .

While at it, remove duplicate 'len(*remoteWriteURLs) > 0' check in the remotewrite.Init() functions,
since this check is already made at the beginning of the function.

Updates #6253
valyala added a commit that referenced this pull request Jul 13, 2024
…ad of old link

The old link was changed globally to the new link in the commit f4b1cbf .
Unfortunately, old links are still posted in new commits :(

This is a follow-up for 680b8c2 .

While at it, remove duplicate 'len(*remoteWriteURLs) > 0' check in the remotewrite.Init() functions,
since this check is already made at the beginning of the function.

Updates #6253
@valyala
Copy link
Collaborator

valyala commented Jul 13, 2024

@AndrewChubatiuk , thanks for the great pull request, which simplifies the app/vmagent/remotewrite package code by removing the deprecated code!

BTW, see small follow-up commit cfc72cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants