victoria-metrics-k8s-stack: optional allowCrossNamespaceImport in GrafanaDashboard(s)

[plevart]

In victoria-metrics-k8s-stack Helm Chart, when values define grafanaOperatorDashboardsFormat.enabled=true, special GrafanaDashboard CRs get rendered that provide dashboards to Grafana Operator (https://grafana-operator.github.io/grafana-operator/). But those CRs don't get imported into Grafana instance when the Grafana Operator is not deployed to the same k8s namespace as the victoria-metrics-k8s-stack chart is, since GrafanaDashboard CRs are created in this namespace.
The provided patch allows overriding an additional boolean attribute in the chart values: grafanaOperatorDashboardsFormat.allowCrossNamespaceImport which is false by default. When set to true, the created GrafanaDashboard CRs will also contain this attribute and Grafana Operator will import them from a namespace that is different than the Grafana Operator's namespace.

[Haleygo]

Thanks for the pull request!
You also need to add this to the dashboard sync script as a part of standard header.
And could you help adding some changelog here?

[plevart]

@Haleygo I see. So the GrafanaDashboard resource template embedded in the python script is rendered with the same "values.yaml" as the dashboard templates in the Helm chart? I can just add the same modifications using same references to .Values dictionary? Out of curiosity, when is this script called?

[plevart]

So, here it is, @Haleygo ... I think I understand it now. The python script is used from the top Makefile to generate various Helm template files in the Helm charts from source JSON files located on various other repositories. So for example, if some other source is introduced, its Helm template can be generated by the script.

I ran the following command from top dir: make sync-dashboards to regenerate the dashboard templates and the result was exactly the same - there were no changes to the files already part of git repo:

[peter@sun vm-helm-charts]$ git diff
diff --git a/Makefile b/Makefile
index 131ea0b..e5ff369 100644
--- a/Makefile
+++ b/Makefile
@@ -143,8 +143,7 @@ sync-rules:
 # Synchronize grafana dashboards in charts/victoria-metrics-k8s-stack/templates/grafana/dashboards
 sync-dashboards:
        docker run --rm \
-               --user $(shell id -u):$(shell id -g) \
-               --mount type=bind,src="$(shell pwd)/charts/victoria-metrics-k8s-stack",dst=/k8s-stack \
+               --volume "$(shell pwd)/charts/victoria-metrics-k8s-stack":/k8s-stack:z \
                -w /k8s-stack/hack/ \
                $(PYTHON_IMAGE) sh -c "\
                        pip3 install --no-cache-dir --no-build-isolation -r requirements.txt --user && python3 sync_grafana_dashboards.py \

I just had to change the Makefile temporarily since I'm using podman in place of docker and podman, by default, runs rootles containers so:

• you do not need (neither want) --user option (uids are mapped and root user in container is mapped to user running the rootless container on the host)
• you need :z option at the end of --volume option (instead of using --mount) so that rootless container can access mounted directory from host due to SELlinux restrictions for rootless containers (the directory on the host and all files in it are re-labeled to system_u:object_r:container_file_t:s0 so that container process can access it).

[Haleygo]

LGTM!
Thanks for contribution!