Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

victoria-metrics-k8s-stack&victoria-metrics-operator: update crd yaml… #845

Merged
merged 4 commits into from
Feb 9, 2024
Merged

victoria-metrics-k8s-stack&victoria-metrics-operator: update crd yaml… #845

merged 4 commits into from
Feb 9, 2024

Conversation

Haleygo
Copy link
Contributor

@Haleygo Haleygo commented Feb 5, 2024 •
edited
Loading

… and bump dependencies

  1. update crd yaml
  2. bump chart/victoria-metrics-k8s-stack dependencies: kube-state-metrics -> 5.16.0, prometheus-node-exporter -> 4.27.0, grafana -> 7.3.0
  3. sync dashboards and rules from upstream
  4. override release fullname for victoria-metrics-k8s-stack's install chart test, otherwise it could have objects collision due to truncated name.

@github-actions github-actions bot added k8s-stack k8s-stack helm chart related issue operator operator helm chart related issue cluster vmcluster helm chart related issue labels Feb 5, 2024
zekker6
zekker6 previously approved these changes Feb 5, 2024
View reviewed changes
@Haleygo Haleygo force-pushed the bump-dependencies branch 8 times, most recently from f44d5e7 to 347700a Compare February 5, 2024 10:09
@Haleygo Haleygo requested a review from zekker6 February 5, 2024 10:30
@Haleygo
Copy link
Contributor Author

Haleygo commented Feb 7, 2024

address #834

zekker6
zekker6 reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@zekker6 zekker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Haleygo LGTM in general, please take a look at one comment and resolve CHANGELOG conflict.

charts/victoria-metrics-cluster/CHANGELOG.md Show resolved Hide resolved
@Haleygo Haleygo mentioned this pull request Feb 9, 2024
Merged
@Haleygo Haleygo requested a review from zekker6 February 9, 2024 06:51
@Haleygo Haleygo merged commit b64b0e0 into master Feb 9, 2024
18 checks passed
@Haleygo Haleygo deleted the bump-dependencies branch February 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekker6 zekker6 zekker6 approved these changes

@Amper Amper Awaiting requested review from Amper Amper is a code owner

Assignees
No one assigned
Labels
cluster vmcluster helm chart related issue k8s-stack k8s-stack helm chart related issue operator operator helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Haleygo @zekker6