added function for histograms merge #73
Conversation
| h.mu.Lock() | ||
| defer h.mu.Unlock() | ||
|
|
||
| b.mu.RLock() |
There was a problem hiding this comment.
does Lock cover RLock as well?
There was a problem hiding this comment.
https://pkg.go.dev/sync#RWMutex.Lock
Lock locks rw for writing. If the lock is already locked for reading or writing, Lock blocks until the lock is available.
so just Lock is enough
There was a problem hiding this comment.
there're locks on different objects - write lock on a target histogram and read lock on src histogram
There was a problem hiding this comment.
oh sorry, makes sense ;)
There was a problem hiding this comment.
potentially, it may cause deadlock.
If goroutine 1 calls merge at histogram A for histogram B and goroutine 2 calls merge at histogram B for histogram A.
The Histogram.Merge() function is needed for VictoriaMetrics/VictoriaMetrics#6314 Updates #73
|
@AndrewChubatiuk , @f41gh7 , @tenmozes , please see the follow-up commit - 7a44715 |
Added function to merge histograms