Fix some issues brought up by the clang static analyzer.

ViennaRSS · Jan 23, 2012 · 25894bf · 25894bf
1 parent de4df4d
commit 25894bf
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/ArticleListView.m b/ArticleListView.m
@@ -297,11 +297,14 @@ -(NSArray *)webView:(WebView *)sender contextMenuItemsForElement:(NSDictionary *
 		if ([newDefaultMenu count] > 0)
 			defaultMenuItems = [newDefaultMenu autorelease];
 		else
+        {
 			defaultMenuItems = nil;
-	}
+            [newDefaultMenu release];
+        }
+    }
 
 	// Return the default menu items.
-	return defaultMenuItems;
+    return defaultMenuItems;
 }
 
 /* initTableView

diff --git a/BitlyAPIHelper.m b/BitlyAPIHelper.m
@@ -67,10 +67,13 @@ - (NSString*)shortenURL: (NSString*)longURL
 		if ((subtree = [responseParser treeByPath:@"bitly/results/nodeKeyVal/shortUrl"]) != nil)
 		{
 			[responseParser release];
+            [request release];
 			return [subtree valueOfElement];
 		}
+        [request release];
 		[responseParser release];
 	}
+    [request release];
 	// TODO: Present error-message to the user?
 	NSLog(@"URL shortening with bit.ly failed!");
 	NSBeep();

diff --git a/GoogleReader.m b/GoogleReader.m
@@ -237,7 +237,8 @@ -(ASIHTTPRequest*)refreshFeed:(Folder*)thisFolder shouldIgnoreArticleLimit:(BOOL
 			// Add to count of new articles so far
 			countOfNewArticles += newArticlesFromFeed;
 				*/
-			}
+            [dict release];
+        }
 
 
 	}];

diff --git a/PluginManager.m b/PluginManager.m
@@ -351,7 +351,7 @@ -(IBAction)pluginInvocator:(id)sender
 					NSString * shortURL = [bitlyHelper shortenURL:[theView viewLink]];
 
 					[urlString replaceString:@"$ArticleLink$" withString:shortURL];
-					[BitlyAPIHelper release];
+					[bitlyHelper release];
 				}
 				else 
 				{
@@ -375,7 +375,7 @@ -(IBAction)pluginInvocator:(id)sender
 
 					// If URL shortening fails, we fall back to the long URL.
 					[urlString replaceString:@"$ArticleLink$" withString:(shortURL ? shortURL : [currentMessage link])];
-					[BitlyAPIHelper release];
+					[bitlyHelper release];
 				}
 				else 
 				{

diff --git a/XMLParser.m b/XMLParser.m
@@ -485,6 +485,7 @@ +(NSCalendarDate *)getDateFromString:(NSString *)dateString
 		return date;
 	}
 	NSLog(@"Conversion error: %@",dateString);
+    [dateFormat release];
 	return date;
 }