Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Empty trash…" context menu to the Trash item #1453

Open
nathanlesage opened this issue Apr 3, 2021 · 3 comments · Fixed by #1522
Open

Add "Empty trash…" context menu to the Trash item #1453

nathanlesage opened this issue Apr 3, 2021 · 3 comments · Fixed by #1522

Comments

@nathanlesage
Copy link

It would be great if the Trash item would offer an "Empty trash…"-entry in its context menu which offers the same functionality as the corresponding menu item. I always first right-click the Trash item until I realise that this item is not there, and then I switch either to the app menu, or press the corresponding shortcut.

Having this item there in the context menu would be great.

Maybe, once could also remove the other items instead of deactivating them (it seems the same context menu is being reused by both collections and the Trash) while at it …?

Thank you for such a great piece of software!

@Eitot
Copy link
Contributor

Eitot commented May 23, 2022

I'd prefer you completely reverse 03a507c.

Having this Empty Trash command for all folders is contrary to the goal of a contextual menu.

Originally posted by @barijaona in #1561 (comment)

I think it is worthwhile having an empty bin action there. The current menu is not particularly contextual. For example, selecting the bin folder has nearly every item disabled and the single-target actions (edit, rename, get info, etc.) still work when multiple feeds/folders are selected (but to which feed is it applied?). This menu needs to be refactored so that it works contextually. I will revisit this once the view-based table is implemented.

@github-actions
Copy link

This issue hasn't been updated in a while so we're going to mark it as stale. stale issues will automatically be closed after 60 days of inactivity. If this issue is still affecting you, please update us on how it affects you, and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. Thank you for your contributions.

@github-actions github-actions bot added the stale ⏳ The issue will be closed 60 days after the label was added and no inactivity has occurred since. label May 25, 2023
@Eitot Eitot removed the stale ⏳ The issue will be closed 60 days after the label was added and no inactivity has occurred since. label May 27, 2023
Copy link

This issue hasn't been updated in a while so we're going to mark it as stale. stale issues will automatically be closed after 60 days of inactivity. If this issue is still affecting you, please update us on how it affects you, and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. Thank you for your contributions.

@github-actions github-actions bot added the stale ⏳ The issue will be closed 60 days after the label was added and no inactivity has occurred since. label May 28, 2024
@Eitot Eitot removed the stale ⏳ The issue will be closed 60 days after the label was added and no inactivity has occurred since. label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants