Bugfixes #644
Bugfixes #644
Conversation
barijaona
commented
May 14, 2016
barijaona
commented
- Issue First article selected after Skip Folder is not marked as read after short delay #643
- Fix issue similar to First article selected after Skip Folder is not marked as read after short delay #643 and progress indicator when switching from/to a folder where Vienna loads full HTML pages
- Fix problem with detection of some feeds
- Fix a hang when OpenReader logging fails
The change of row selection is already calling the -tableViewSelectionDidChange: delegate, which performs its own update. This fixes an update problem when skipping from a folder which loads full HTML pages to another one which doesn't.
Avoids a loop.
- solve an issue with URL strings provided by Flickr - add an assertion - fix comments
| @@ -202,6 +202,7 @@ -(IBAction)doSubscribe:(id)sender | |||
| // Validate the subscription, possibly replacing the feedURLString with a real one if | |||
| // it originally pointed to a web page. | |||
| rssFeedURL = [subscriptionModel verifiedFeedURLFromURL:rssFeedURL]; | |||
| NSAssert(rssFeedURL != nil, @"No valid URL verified to attempt subscription !"); | |||
There was a problem hiding this comment.
This always causes an assertion failure as rssFeedURL is basically always != nil.
There was a problem hiding this comment.
This ensures rssFeedURL is not nil.
It is aimed at detecting problems in SubscriptionModel’s -verifiedFeedURLFromURL:
There was a problem hiding this comment.
Yes, but it always crashes the program whether or not a valid URL has been entered.
There was a problem hiding this comment.
I have not encountered that problem.
According to the doc, NSAssert(condition, desc, ...) will fail if condition evaluates to NO.
A similar use case here : https://github.com/ViennaRSS/vienna-rss/blob/master/src/ArticleController.m#L336
There was a problem hiding this comment.
Try this valid feed: https://feeds.feedburner.com/UnifiedArsTechnicaFeed?format=xml
It's always set to nil for me and therefore triggers the assertion failure.
EDIT: OK I see now the issue is in SubscriptionModel, as this feed url works: http://www.abc.net.au/news/feed/51120/rss.xml
| } | ||
| return rssFeedURL.absoluteURL; | ||
| return myURL; |
There was a problem hiding this comment.
This change seems to be what is causing the "new" issue. If myURL isn't set because extractFeeds returns NO, then we get nil returned even if the original URL was OK.
|
Commit added. |
|
great, thanks! |
