Add ViewComponent::Deprecation #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/silence-deprecations-during-tests
branch
2 times, most recently
from
ef4943b
to
584d5db
Compare
Spone
reviewed
Feb 14, 2022
Spone
reviewed
Feb 14, 2022
Spone
reviewed
Feb 14, 2022
elia
force-pushed
the
elia/silence-deprecations-during-tests
branch
from
584d5db
to
312954b
Compare
Spone
reviewed
Feb 14, 2022
Spone
approved these changes
Feb 14, 2022
This should allow consumers to see deprecation warnings that correctly mention the next version of VC. Co-Authored-By: Elia Schito <elia@schito.me> Co-Authored-By: Hans Lemuet <Spone@users.noreply.github.com>
``` lib/view_component/polymorphic_slots.rb:42: warning: method redefined; discarding old header lib/view_component/polymorphic_slots.rb:42: warning: previous definition of header was here lib/view_component/polymorphic_slots.rb:42: warning: method redefined; discarding old items lib/view_component/polymorphic_slots.rb:42: warning: previous definition of items was here ```
…mplate Was generating this warning: ``` test/sandbox/app/components/jbuilder_component.json.jbuilder:1: warning: `frozen_string_literal' is ignored after any tokens ``` See also: https://bugs.ruby-lang.org/issues/16602
elia
force-pushed
the
elia/silence-deprecations-during-tests
branch
from
6fe37cb
to
30edbb7
Compare
camertron
approved these changes
Feb 14, 2022
|
👋 thanks for picking up what I started and never got back around to 🙇 💖 |
Co-authored-by: Cameron Dutro <camertron@github.com>
BlakeWilliams
pushed a commit
that referenced
this pull request
Feb 15, 2022
* Add ViewComponent::Deprecation This should allow consumers to see deprecation warnings that correctly mention the next version of VC. Co-Authored-By: Elia Schito <elia@schito.me> Co-Authored-By: Hans Lemuet <Spone@users.noreply.github.com> * Avoid warning about polymorphic slots getter being redefined ``` lib/view_component/polymorphic_slots.rb:42: warning: method redefined; discarding old header lib/view_component/polymorphic_slots.rb:42: warning: previous definition of header was here lib/view_component/polymorphic_slots.rb:42: warning: method redefined; discarding old items lib/view_component/polymorphic_slots.rb:42: warning: previous definition of items was here ``` * Remove the unsupported frozen_string_literal comment from jbuilder template Was generating this warning: ``` test/sandbox/app/components/jbuilder_component.json.jbuilder:1: warning: `frozen_string_literal' is ignored after any tokens ``` See also: https://bugs.ruby-lang.org/issues/16602 * Add deprecation horizon management to the release script * Update deprecation copy for manually loading the engine Co-authored-by: Cameron Dutro <camertron@github.com> --- Co-authored-by: Max Beizer <max.beizer@gmail.com> Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com> Co-authored-by: Cameron Dutro <camertron@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should allow consumers to see deprecation warnings that correctly mention the next version of VC.
Silencing is already a feature of AS::Deprecation
Closes #586 and closes #1273 (this was built starting from those PRs).