Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ViewComponent::Deprecation #1277

Merged
merged 5 commits into from
Feb 15, 2022
Merged

Commits on Feb 14, 2022

  1. Add ViewComponent::Deprecation

    This should allow consumers to see deprecation warnings that correctly
    mention the next version of VC.
    
    Co-Authored-By: Elia Schito <elia@schito.me>
    Co-Authored-By: Hans Lemuet <Spone@users.noreply.github.com>
    3 people committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    39e1ef1 View commit details
    Browse the repository at this point in the history
  2. Avoid warning about polymorphic slots getter being redefined

    ```
    lib/view_component/polymorphic_slots.rb:42: warning: method redefined; discarding old header
    lib/view_component/polymorphic_slots.rb:42: warning: previous definition of header was here
    lib/view_component/polymorphic_slots.rb:42: warning: method redefined; discarding old items
    lib/view_component/polymorphic_slots.rb:42: warning: previous definition of items was here
    ```
    elia committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    0729dc1 View commit details
    Browse the repository at this point in the history
  3. Remove the unsupported frozen_string_literal comment from jbuilder te…

    …mplate
    
    Was generating this warning:
    
    ```
    test/sandbox/app/components/jbuilder_component.json.jbuilder:1: warning: `frozen_string_literal' is ignored after any tokens
    ```
    
    See also: https://bugs.ruby-lang.org/issues/16602
    elia committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    aba868c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    30edbb7 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Update deprecation copy for manually loading the engine

    Co-authored-by: Cameron Dutro <camertron@github.com>
    elia and camertron committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    561edb7 View commit details
    Browse the repository at this point in the history