Raise error if translations are used in initializer #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camertron
approved these changes
Mar 28, 2023
sandbergja
added a commit
to sandbergja/blacklight
that referenced
this pull request
Apr 19, 2023
… initializer This is due to this upstream PR: ViewComponent/view_component#1666
sandbergja
added a commit
to projectblacklight/blacklight
that referenced
this pull request
Apr 19, 2023
* Use updated capybara filter_block syntax teamcapybara/capybara#2617 changed how blocks are evaluated. Thanks to @maxkadel for finding this change! * rubocop -a * ViewComponent 3 compatibility: don't call i18n methods in a component initializer This is due to this upstream PR: ViewComponent/view_component#1666
sandbergja
added a commit
to sandbergja/blacklight
that referenced
this pull request
Apr 27, 2023
* Use updated capybara filter_block syntax teamcapybara/capybara#2617 changed how blocks are evaluated. Thanks to @maxkadel for finding this change! * rubocop -a * ViewComponent 3 compatibility: don't call i18n methods in a component initializer This is due to this upstream PR: ViewComponent/view_component#1666
cbeer
pushed a commit
to projectblacklight/blacklight
that referenced
this pull request
Aug 10, 2023
* Use updated capybara filter_block syntax teamcapybara/capybara#2617 changed how blocks are evaluated. Thanks to @maxkadel for finding this change! * rubocop -a * ViewComponent 3 compatibility: don't call i18n methods in a component initializer This is due to this upstream PR: ViewComponent/view_component#1666
cbeer
pushed a commit
to projectblacklight/blacklight
that referenced
this pull request
Aug 10, 2023
* Use updated capybara filter_block syntax teamcapybara/capybara#2617 changed how blocks are evaluated. Thanks to @maxkadel for finding this change! * rubocop -a * ViewComponent 3 compatibility: don't call i18n methods in a component initializer This is due to this upstream PR: ViewComponent/view_component#1666
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
* remove unnecessary include * Raise error if translations are used in initializer * Update base.rb * Update initializer_translations_component.rb * Update lib/view_component/base.rb
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
* remove unnecessary include * Raise error if translations are used in initializer * Update base.rb * Update initializer_translations_component.rb * Update lib/view_component/base.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After exploring a potential solution in #1617, this PR raises a clear error that guides folks towards our recommended approach.
Closes #1577
cc @jcoyne