fix: IBDesignablesAgent crash on rendering IB_DESIGNABLE views #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I am looking into that. The swizzling there is all legacy and ViewDeck 3.0.0 will not have anything in it. So I am not planning on refactoring that stuff anymore. But I'll consider your fix for the next bug fix release. Thanks for contributing! |
|
Thanks, Michael! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Unfortunately swizzling of UIView/UIViewController methods crashes IBDesignablesAgent when it tries to render IB_DESIGNABLE views in Interface Builder. I suggest escaping swizzling for TARGET_INTERFACE_BUILDER.
And it seems to me a better approach for swizzling was described by Peter Steingberg in the following blog post:
http://petersteinberger.com/blog/2014/a-story-about-swizzling-the-right-way-and-touch-forwarding/
Looking forward to hearing from you.