Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to build the repl command using a lua function #300

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented Oct 19, 2022

This is useful e.g. if the command has to take a path or directory as an argument.

In my case, cabal new-repl has to take the package name as an argument if a project has more than one package.
With a function, I can determine the package's name and build the appropriate command.

Another use case would be if there are different ways to open a repl.
In Haskell, the command may have to be

  • stack ghci ...
  • cabal new-repl...
  • ghci ...

depending on the build tool.

This is useful e.g. if the command has to take a path or directory
as an argument.
@hkupty
Copy link
Collaborator

hkupty commented Nov 8, 2022

That's a great feature! Thanks a lot for the PR and sorry for not reviewing it before!

@hkupty hkupty merged commit 9ba92cb into Vigemus:master Nov 8, 2022
@mrcjkb
Copy link
Contributor Author

mrcjkb commented Nov 8, 2022

Thanks for merging :)
It's an awesome plugin you've developed!

yelircaasi pushed a commit to yelircaasi/iron.nvim that referenced this pull request Apr 13, 2023
* feat: allow to build the repl command using a lua function

This is useful e.g. if the command has to take a path or directory
as an argument.

* feat: pass current buffer to repl command

Co-authored-by: Marc Jakobi <marc.jakobi@tiko.energy>
Co-authored-by: Henry John Kupty <hkupty@users.noreply.github.com>
hkupty added a commit that referenced this pull request Apr 13, 2023
* feat: allow to build the repl command using a lua function

This is useful e.g. if the command has to take a path or directory
as an argument.

* feat: pass current buffer to repl command

Co-authored-by: Marc Jakobi <marc.jakobi@tiko.energy>
Co-authored-by: Henry John Kupty <hkupty@users.noreply.github.com>
hkupty added a commit that referenced this pull request Apr 13, 2023
* feat: allow to build the repl command using a lua function

This is useful e.g. if the command has to take a path or directory
as an argument.

* feat: pass current buffer to repl command

Co-authored-by: Marc Jakobi <marc.jakobi@tiko.energy>
Co-authored-by: Henry John Kupty <hkupty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants