Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ShippingAddress.cs #215

Closed
wants to merge 2 commits into from
Closed

Conversation

baer999
Copy link

@baer999 baer999 commented Jan 26, 2021

@Viincenttt
Copy link
Owner

Hi @baer999 ,

This pull request only contains the ShippingAddress.cs file, but without any references to it, it won't be used. Did you forget to add any other files?

Kind regards,
Vincent

@baer999
Copy link
Author

baer999 commented Jan 30, 2021

Hi @Viincenttt
yes, like described in my issue...
It is my first pull request, so sorry for the un-knowledge...
changed the file in web because via git add / commit / push I got an "not authorized" with my user....

#214

Does this help you?

@baer999
Copy link
Author

baer999 commented Feb 8, 2021

@Viincenttt
I updated the Pull Request in order that it can easily be used.
Let me know if this is fine and Kind regards.

@Viincenttt
Copy link
Owner

Viincenttt commented Feb 8, 2021

Hi @baer999 ,

Thank you for your pull request. It is already possible to add the shipping address to a PaymentRequest. There is a PayPalPaymentRequest that has a AddressObject that contains all the needed properties. For example:

var payPalPaymentRequest = new PayPalPaymentRequest() {
                ShippingAddress = new AddressObject() {
                    City = "Rotterdam",
                    // etc
                }
            };

Let me know if there anything I'm missing. If not, you can close this pull request :)

@baer999 baer999 closed this Feb 8, 2021
@baer999
Copy link
Author

baer999 commented Feb 8, 2021

already possible with other structure!

@baer999 baer999 deleted the patch-2 branch February 8, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants