Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use 'bin/vint' in tests to avoid calling an installed vint copy #262

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

Coacher
Copy link
Collaborator

@Coacher Coacher commented Jan 21, 2018

If test command is just 'vint' and you already have vint installed, then
the test suite calls an installed binary in majority of cases since cwd
usually goes last or missing from PATH. Use 'bin/vint' in tests instead.

Fixes issue #223.

If test command is just 'vint' and you already have vint installed, then
the test suite calls an installed binary in majority of cases since cwd
usually goes last or missing from PATH. Use 'bin/vint' in tests instead.

Fixes issue #223.
@Coacher Coacher self-assigned this Jan 21, 2018
@Coacher Coacher requested a review from Kuniwak January 21, 2018 17:19
Copy link
Member

@Kuniwak Kuniwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@Kuniwak Kuniwak merged commit 8c34196 into master Jan 23, 2018
@Kuniwak Kuniwak deleted the issue-223 branch January 23, 2018 06:21
@Kuniwak Kuniwak mentioned this pull request Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants